renamed apiserver to httpserver #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applike-ss
requested changes
Feb 9, 2024
applike-ss
approved these changes
Feb 9, 2024
applike-ss
requested changes
Feb 13, 2024
applike-ss
force-pushed
the
apiserver-to-httpserver
branch
2 times, most recently
from
153825e
to
269eb8a
Compare
j4k4
force-pushed
the
apiserver-to-httpserver
branch
from
269eb8a
to
503c59b
Compare
applike-ss
requested changes
Feb 14, 2024
| @@ -215,27 +160,107 @@ func (a *ApplicationDashboardDefinitionDataSource) Read(ctx context.Context, req | |||
| response.Diagnostics.Append(diags...) | |||
| } | |||
|
|
|||
| func getEc2AndEcsData(ctx context.Context, response *tfsdk.ReadDataSourceResponse, ecsClusterName string, ecsServiceName string) ([]builder.ElbTargetGroup, string, error) { | |||
| func (a *ApplicationDashboardDefinitionDataSource) getResourceNames(ctx context.Context, state *ApplicationDashboardDefinitionData, response *tfsdk.ReadDataSourceResponse) (builder.ResourceNames, error) { | |||
There was a problem hiding this comment.
Should we use a pointer as the first return value when we have an error in one of the following return values?
Suggested change
| func (a *ApplicationDashboardDefinitionDataSource) getResourceNames(ctx context.Context, state *ApplicationDashboardDefinitionData, response *tfsdk.ReadDataSourceResponse) (builder.ResourceNames, error) { | |
| func (a *ApplicationDashboardDefinitionDataSource) getResourceNames(ctx context.Context, state *ApplicationDashboardDefinitionData, response *tfsdk.ReadDataSourceResponse) (*builder.ResourceNames, error) { |
applike-ss
approved these changes
Feb 14, 2024
j4k4
force-pushed
the
apiserver-to-httpserver
branch
from
c015006
to
184002a
Compare
j4k4
force-pushed
the
apiserver-to-httpserver
branch
from
184002a
to
ed7f4fc
Compare
j4k4
added a commit
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.